Dictionary Key "-Serial Number-" Still has Dashes #10

New Issue

engineerjoe440 · 2022-09-05T02:32:24Z

engineerjoe440 commented

2022-09-05 02:32:24 +00:00

Looks like we're still using some dashes in at least some of the dictionary keys, since the "Serial Number" key is still appearing with dashes on either side, as shown in the database file in this, most recent, commit.

That should be something pretty easy to "knock out," just by updating where the key is defined. We need to remove those dashes, if we want to be really consistent across the code.

Your Challenge

should you wish to accept it

Find the key that still uses "-Serial Number-" and change it to "Serial Number"

Need a hint?

Look in this block of code... 😉

Looks like we're still using some dashes in at least some of the dictionary keys, since the "Serial Number" key is still appearing with dashes on either side, as shown in the database file in [this, most recent, commit](https://gitea.stanleysolutionsnw.com/Potlatch-Loggers/ComputerKeeper/commit/3f56ee7a8152dc987bf1abc8cbd26a7c59b3e95a#diff-882a43610b9835dd51ca4ad37a0967fa0205e328). That should be something pretty easy to "knock out," just by updating where the key is defined. We need to remove those dashes, if we want to be really consistent across the code. ## Your Challenge *should you wish to accept it* 1. Find the key that still uses "`-Serial Number-`" and change it to "`Serial Number`" <details> <summary>Need a hint?</summary> Look in <a href="https://gitea.stanleysolutionsnw.com/Potlatch-Loggers/ComputerKeeper/src/branch/main/main.py#L22-L30">this</a> block of code... :wink: </details>

engineerjoe440 added this to the Initial Prototype milestone 2022-09-05 02:32:24 +00:00

engineerjoe440 added the

bug

core

labels 2022-09-05 02:32:24 +00:00

joshb was assigned by engineerjoe440

2022-09-05 02:32:24 +00:00

engineerjoe440 commented

2022-09-07 00:26:05 +00:00

Closed in commit: cbfe80ac1c

engineerjoe440 closed this issue

2022-09-07 00:26:12 +00:00